Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify variables #476

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Clarify variables #476

merged 3 commits into from
Dec 12, 2024

Conversation

timothymcmackin
Copy link
Collaborator

@timothymcmackin timothymcmackin commented Nov 27, 2024

Clarify a few places where we use variables without explaining what they are. We can assume that $HOME and $PATH are defined, but if I use $MY_ACCOUNT that should have been explicitly defined.

@timothymcmackin timothymcmackin self-assigned this Nov 27, 2024
@timothymcmackin timothymcmackin requested a review from a team as a code owner November 27, 2024 19:52
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Nov 27, 2024 7:52pm

@timothymcmackin timothymcmackin merged commit ee0fd83 into main Dec 12, 2024
4 checks passed
@timothymcmackin timothymcmackin deleted the clarify-variables branch December 12, 2024 17:52
For example, this command initializes the DAL node with the address of a local `octez-node` instance on port 8732 and stores data in the default DAL node directory (`~/.tezos-dal-node`):

```bash
octez-dal-node config init --endpoint http://127.0.0.1:8732 --attester-profiles="$MY_ADDRESS"
octez-dal-node config init --endpoint http://127.0.0.1:8732 \
--attester-profiles=tz1QCVQinE8iVj1H2fckqx6oiM85CNJSK9Sx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: consider using ellipses to avoid having such big and concrete hashes:tz1...

Copy link
Collaborator

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants